Write “AS” in uppercase in Dockerfile#400
Merged
marc-vanderwal merged 1 commit intozonemaster:developfrom Dec 3, 2024
Merged
Conversation
Running “docker build” on Zonemaster-Engine caused a warning to appear on my test system: 1 warning found (use docker --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
marc-vanderwal
requested review from
MichaelTimbert,
matsduf,
mattias-p and
tgreenx
matsduf
approved these changes
Dec 2, 2024
tgreenx
approved these changes
Dec 2, 2024
tgreenx
added
the
V-Patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a warning that appeared when running
docker buildon my test system (Rocky Linux 9):Context
Release testing for 2024.2.
Changes
How to test this PR
Build the container for
zonemaster-cliaccording to the documented procedure. No warning should appear. (Although one should also check if the warning is generated by reverting this change.)