Merged
Conversation
Try to install as many prerequisite packages from binary packages as possible in order to speed up the build. Some packages are both build-time and runtime dependencies, and because this is a two-stage Docker build, some packages need to be installed twice.
marc-vanderwal
requested review from
MichaelTimbert,
matsduf,
mattias-p and
tgreenx
Contributor
|
Does this increase or decrease the Docker image size? |
Contributor
Author
|
There is a slight decrease. To compare:
|
matsduf
added
the
V-Patch
tgreenx
approved these changes
Jun 25, 2024
matsduf
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR amends the Dockerfile for zonemaster-cli so as to install as many prerequisite packages from binary packages as possible, thereby speeding up the build.
Context
Release testing for v2024.1.
Changes
How to test this PR
Try to build the Docker image. The build process should only pick up six small packages from CPAN. Notably, Moose shouldn’t be picked up from CPAN.