Improve implementation for JSON and raw options#309
Improve implementation for JSON and raw options#3096 commits merged intodevelopfrom unknown repository
Conversation
|
A big improvement, definitely, which reduces the combinations of command-line options that do nothing (e.g. With this design, all combinations make sense, except for one: Because
|
|
Thanks for the review and comments. I've updated the PR to display error and/or warning messages to the user. |
* remove comment for ending blocks * clarify translation condition
The --json-translate option translates the message tag. This is similar to the already documented --no-raw option. Therefore use --[no-]raw instead of --[no-]json-translate
Use --[no-]raw instead.
|
Rebased to fix conflicts and incorporate latest release changes. Please re-review. |
marc-vanderwal
left a comment
There was a problem hiding this comment.
Looks good to me.
v2023.1 Release testingBasic testing:
Bugs:
Observations:
|
Purpose
Continue the work to align the Zonemaster-CLI implementation with its own documentation.
Context
Follow-up on #308
#247 (comment)
Changes
--json-streamentail--json--[no-]json-translate, use--[no-]rawinsteadHow to test this PR
Test several configurations mixing
--json,--raw,--json-stream.