Zonemaster::LDNS and libldns versions

[ghost]

Purpose

Show which versions of Zonemaster-LDNS and NL NetLabs LDNS are being used.
Remove module versions.

Context

Addresses #181

Changes

CLI.pm and version() method.

How to test this PR

Verify that the following command returns 2 new lines LDNS version and libldns version:

$ zonemaster-cli --version
Zonemaster-CLI version v5.0.1                                                                                          
Zonemaster-Engine version v4.6.1     
Zonemaster-LDNS version 3.1.0                    
NL NetLabs LDNS version 1.8.3

[matsduf]

Show which versions of Zonemaster::LDNS and libldns are being used.

That is a good idea.

$ zonemaster-cli --version
CLI version:    v5.0.1
Engine version: v4.6.1
LDNS version: 3.1.0
libldns version: 1.8.3
...

However, I think that more updates should be done. Just as the issue points out the module numbers do not add anything. I suggest that they should be removed.

Secondly, we should use the full name of the Zonemaster components, especially it is problematic to refer to "LDNS" when we mean Zonemaster-LDNS since LDNS is a different code. Compare with how it is displayed when running the web GUI.

Thirdly, I think it would be better to refer to the NL NetLabs code as LDNS since that is what they call it. I suggest that "zonemaster-cli --version" outputs the following (and nothing else):

$ zonemaster-cli --version
Zonemaster-CLI version v5.0.1
Zonemaster-Engine version v4.6.1
Zonemaster-LDNS version 3.1.0
NL NetLabs LDNS version 1.8.3

[ghost]

Updated to address your remarks.

[matsduf]

I also fee this is "Minor", but technically, isn't this a change of API, i.e. "Major"?

[ghost]

I also fee this is "Minor", but technically, isn't this a change of API, i.e. "Major"?

Indeed. It was a "minor" change at first where only new lines were added. Since we remove and update the existing output, it becomes a "major" change.

[mattias-p]

I've successfully tested this as part of release testing for 2023.1.