Main database structure and seeders #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-astral-cat
force-pushed
the
main_database_structure_and_seeders
branch
2 times, most recently
from
308a66c to
b255dca
Compare
crazybolillo
reviewed
Sep 6, 2023
| $table->string('name', 100); | ||
| $table->string('ip', 15)->nullable(); //Just IPv4 | ||
| $table->dateTime('last_seen')->nullable(); | ||
| $table->boolean('transmitting')->default(false); |
There was a problem hiding this comment.
Perhaps it is better to name it as working?
There was a problem hiding this comment.
It will renamed to working
| $table->float('reflow_gradient'); | ||
| $table->float('ramp_up_gradient'); | ||
| $table->float('reflow_peak_temp'); | ||
| $table->float('reflow_max_time'); |
There was a problem hiding this comment.
Since this is measured in seconds it could also be unsigned integer
There was a problem hiding this comment.
As I didn't know the possible values for this fields I decided to use floats. But I will make the change for unsigned integers.
rick-astral-cat
force-pushed
the
main_database_structure_and_seeders
branch
from
b255dca to
b50885b
Compare
rick-astral-cat
force-pushed
the
main_database_structure_and_seeders
branch
from
b50885b to
4d7cad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add necessary migrations and seeders for main database structure and database diagram for reference.
Closes #7