Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Update README for FCM #710

Closed
wants to merge 1 commit into from
Closed

Conversation

alexsegura
Copy link

@alexsegura alexsegura commented Apr 10, 2018

Hello,

When using FCM instead of GCM, some lines should be removed from AndroidManifest.xml, as explained here.

If you don't remove them, notifications are received twice 🙂

I updated the README.

If you want, I can rework the documentation a little more to explain usage with FCM, this would fix some issues as the library is working well with FCM.

@heyman333
Copy link

heyman333 commented Jun 6, 2018

hello @alexsegura
if above lines were deleted, we won't be able to use onNotification method anymore

@alexsegura
Copy link
Author

With this configuration it works, and onNotification is called.

Please note that I'm speaking about using FCM 🙂

@iamarkdev
Copy link

Our fork has FCM working.

https://github.com/Fanapptic/react-native-push-notification

@Gp2mv3
Copy link
Contributor

Gp2mv3 commented Jul 4, 2018

Can we merge #717 which also includes changes done in this PR ?

@alexsegura
Copy link
Author

@Gp2mv3 yes, you can close this one then. Thank you.

@Gp2mv3 Gp2mv3 closed this Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants