This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Implement removeAllDeliveredNotifications. #636
Closed
+18
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function clears delivered notifications, but not scheduled local notifications. Since it's in react-native's PushNotificationIOS, adding it to react-native-push-notification brings us closer to feature parity. And this is a simple, but important one. See RN Docs.
The following code can be used to test this functionality:
This makes notifications clear on startup and when the app enters foreground. When you open the app, all notifications for the app in the notification center should disappear. To further test it, schedule a notification, then put the app in the background and then the foreground again. The scheduled notification should appear anyway. Canceling scheduled local notifications was a blocker for my app before this PR.
This PR addresses one point in #427. I may implement the other new features if I find a need for them.