fixed duplicate sending of notifications in the foreground #1760
Conversation
| @@ -172,7 +172,7 @@ private void handleRemotePushNotification(ReactApplicationContext context, Bundl | |||
| jsDelivery.notifyRemoteFetch(bundle); | |||
| } | |||
|
|
|||
| if (config.getNotificationForeground() || !isForeground) { | |||
| if (config.getNotificationForeground() && !isForeground) { | |||
There was a problem hiding this comment.
This condition doesn't make sense:
If "Allow notifications in foreground" and "Not in foreground":
Then Trigger the notification.
you probably missed a configuration on the AndroidManifest or in your app configuration...
There was a problem hiding this comment.
With those changes showing local notifications works as expected (without duplication)
I use this repo in combine with react-native-firebase v6 messaging (for showing local notifications only)
There was a problem hiding this comment.
I'm not saying this change is not working for you, I'm saying that this change doesn't have sense (see the comment above).
If you experience duplicate notifications, this means there is a configuration issue in your project.
There was a problem hiding this comment.
NOTE: localNotification() works without changes in the application part
this is from readme, i use local notifications only with this library.
There was a problem hiding this comment.
anyway, thank you for great library
There was a problem hiding this comment.
<!-- Change the value to true to enable pop-up for in foreground (remote-only, for local use ignoreInForeground) -->
<meta-data android:name="com.dieam.reactnativepushnotification.notification_foreground"
android:value="false"/>There was a problem hiding this comment.
Thanks, i've created a new PR about readme updating - #1762
No description provided.