Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Add support for specifying a delegate FirebaseMessagingService #1589

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

james-relyea
Copy link
Contributor

@james-relyea james-relyea commented Aug 10, 2020

Fixes #1356

We're using multiple push providers and thus need to use a delegate service for handling our notifications.

This PR adds ability to specify a delegate service during instantiation as this library will otherwise throw an NPE when attempting to invoke getReactNativeHost() when handling a remote message in RNReceivedMessageHandler.

@Dallas62 Dallas62 self-assigned this Aug 10, 2020
@Dallas62 Dallas62 changed the base branch from master to dev August 12, 2020 08:22
@Dallas62 Dallas62 merged commit acac514 into zo0r:dev Aug 12, 2020
@Dallas62
Copy link
Collaborator

Hi @james-relyea
Thanks for this PR !
Will be released in the next version of the library
Best regards,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional FirebaseMessagingService
3 participants