Add Android messageId to enable integration with react-native-firebase/messaging#1510
Conversation
…th react-native-firebase/messaging onNotificationOpenedApp
mikehardy
left a comment
There was a problem hiding this comment.
I help maintain react-native-firebase and just reviewed the corresponding change in that repo. As mentioned there, I can't see how this would be harmful - at least in our repo - and the value is obvious. I approved it there but I'm just one vote and I may have missed something. Just wanted to comment here that it seems like a useful capability and I like the idea, for what it's worth. Cheers
|
The related PR in react-native-firebase has passed the required number of reviews, so it will merge just pending @aranda-adapptor signing the CLA there, so as this is a cross-package PR basically, just keeping you guys up to date that this is good on our end. Cheers |
|
Hi @aranda-adapptor |
|
Will add the change for Scheduled notifications, thanks ! |
|
@Dallas62 thanks for finishing that off, I was on vacation and it would've taken a little while to figure out the required changes 👍 |
This PR is part of the solution to the following problem:
@react-native-firebase/messagingfor delivery and handling or remote messages and notifications when the app is killed or in the backgroundreact-native-push-notificationto display these notifications when the app is in the foregroundmessaging().getInitialNotificationormessaging().onNotificationOpenedAppRN firebase messaging stores the remote notification payload and looks it up based on this "message_id" intent extra. The full solution requires minor changes to RN firebase too, which will be submitted as another PR soon.