Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Fix undefined fallback variables in build gradle #1170

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

owinter86
Copy link
Contributor

@owinter86 owinter86 commented Aug 12, 2019

The fallback variables defined in the build gradle are all undefined
DEFAULT_SUPPORT_LIB_VERSION
DEFAULT_GOOGLE_PLAY_SERVICES_VERSION
DEFAULT_FIREBASE_MESSAGING_VERSION

Edit: not sure why there were downvotes on this, so I have provided a little more clarification.

acfa3bf

This particular commit Refractors the hard coded variables to the safeGet method fallback, but it seems like the variables above were missed or the changes lost in a merge conflict, this PR fixes this issue and ensures android builds correctly.

The fallback variables defined in the build gradle are all undefined
DEFAULT_SUPPORT_LIB_VERSION
DEFAULT_GOOGLE_PLAY_SERVICES_VERSION
DEFAULT_FIREBASE_MESSAGING_VERSION
@tholhubner
Copy link

@owinter86 what is going on with this? I am having issues with the same thing, I have no idea how to proceed.

@owinter86
Copy link
Contributor Author

Not sure why this PR is getting downvoted, as it’s fixing the issue with the undefined variables.

Looking over the recent commits it looks like this may have occurred during a merge conflict with a local and remote master merge.

But for the time being if you must upgrade to the latest version, you can use the current commit on this PR.

"react-native-push-notification": "https://github.com/owinter86/react-native-push-notification.git#fe1da09029bb169cb4afc40ddd9268a4cf527103",

Otherwise downgrade to an earlier version or wait for this PR to get merged.

@zo0r zo0r merged commit df4ae93 into zo0r:master Aug 13, 2019
@tholhubner
Copy link

@owinter86 thanks for the update.

@MattyK14
Copy link

@owinter86 I downvoted because I thought it could have been better implemented. Too busy at the time to make a comment or suggestion. I think the ternary expression should have remained with the false case being your changes.

@owinter86
Copy link
Contributor Author

@MattyK14 I believe that what the safeGet method is doing.

@MattyK14
Copy link

@owinter86 you are correct, my bad!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants