This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Fix undefined fallback variables in build gradle #1170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback variables defined in the build gradle are all undefined
DEFAULT_SUPPORT_LIB_VERSION
DEFAULT_GOOGLE_PLAY_SERVICES_VERSION
DEFAULT_FIREBASE_MESSAGING_VERSION
Edit: not sure why there were downvotes on this, so I have provided a little more clarification.
acfa3bf
This particular commit Refractors the hard coded variables to the safeGet method fallback, but it seems like the variables above were missed or the changes lost in a merge conflict, this PR fixes this issue and ensures android builds correctly.