Why not getting as much info as we can with getDeliveredNotifications on android

[bennyscetbun]

Hi all,
I was wondering if there was a good reason for this:

react-native-push-notification/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java

Line 736 in a9083c8

* stay consistent to the return structure in

We could get much more information like the big_text for example. (i am sure that we could also get the "user_info")

So why aren't we getting them on android?

PS: it s not consistent with what getDeliveredNotifications returns in IOS anymore by the way.

[Dallas62]

Hi @bennyscetbun
When this change was made, userInfo on Android wasn't available.
Now it's ok to be integrated.
PR are welcome, or I will take a look later 😉
Regards,

[bennyscetbun]

Thanks for the quick answer.
If i do a pr and to avoid wasting time.
Do you prefer to stick to the facebook dataset or should we put as much data as we can? (Like when you create notification)

[Dallas62]

Oh wait, I was looking at the wrong function. I thought it was getScheduledLocalNotifications .
I'm not sure if we can retrieve data of delivered notifications, didn't test.
Original implementation is #909
We can probably extract userInfo from extras, bu not sure there is more useful information.

[s-fletcher]

@Dallas62 regarding getScheduledLocalNotifications not returning userInfo, it seems to already do so. It's just not documented in the types or readme.

https://github.com/zo0r/react-native-push-notification/blob/master/index.js#L546

I've created a PR to address this #1910

[litinskii]

+1 to add userInfo to getDeliveredNotifications

[McDreamy]

does it work for delivered local notification for getDeliveredNotifications in android?

[bennyscetbun]

Sadly on android we could get just a little bit more of information but not the all the userInfo like in IOs. I thought we would be able to do so. I was wrong.
I am closing the issue for now