onNotification not being called when app was killed on iOS

[mathiasmoeller]

Bug

I am sending local notifications using react-native-background-fetch. This works good. When the user clicks on a notification I redirect him to a certain screen. This always works in Android.
For iOS it is working when the app is in foreground or background. When the app was killed and the user clicks on a notification, the app launches but the onNotification handler is not being called.
I call PushNotification.configure from index.js, so timing should not be the issue.

I followed the fix here to get onNotification to work in foreground and background.

Environment info

react-native info output:

 info 
  React Native Environment Info:
    System:
      OS: macOS 10.15.5
      CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
      Memory: 4.00 GB / 32.00 GB
      Shell: 5.7.1 - /bin/zsh
    Binaries:
      Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
      npm: 6.13.6 - ~/.nvm/versions/node/v10.16.3/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
      Android SDK:
        API Levels: 23, 26, 27, 28, 29
        Build Tools: 23.0.1, 26.0.3, 27.0.3, 28.0.3, 29.0.3
        System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom_64
    IDEs:
      Xcode: 11.5/11E608c - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3 
      react-native: 0.59.5 => 0.59.5 
    npmGlobalPackages:
      react-native-cli: 2.0.1

Library version: the development branch of this repo for the latest Android notification action fixes

Steps To Reproduce

1. Configure the onNotification handler in index.js
2. Send a push notification while the app is killed
3. Check if the onNotification handler was called when the notification is clicked

Describe what you expected to happen:

onNotification should be called when coming from Foreground/Background or when the app was killed

[Dallas62]

Hi,
The behavior of iOS depends on when you put in AppDelegate,
Check the iOS repository for this.

[mathiasmoeller]

Okay I will recreate the issue there!

[mathiasmoeller]

react-native-push-notification/ios#143

[Dallas62]

I just saw your issue with AppDelegate, the Apple documentation say that:

application didReceiveLocalNotification:(UILocalNotification *)notification

Is deprecated, and there is other issues on ios repo, to repace with something like « willPresentNotification ».
But local notification in background doesn’t work

[mathiasmoeller]

It works fine for me in the background. Just not when the app is killed.
Or what do you mean with with "local notification in background doesn’t work"?

[Dallas62]

In the new Notification SDK of Apple, local notifications doesn’t trigger the application if the user doesn’t interact with the notification .

[Dallas62]

Hi again, just to be sure, can you provide the content of .configure() ?

Reading your case and the version you are using, there might be a side affect of an Android change.

https://github.com/zo0r/react-native-push-notification/blob/dev/CHANGELOG.md

Now local scheduled notifications trigger onNotification before display #574.

[mathiasmoeller]

Sorry @Dallas62, I was very busy the whole week.
My .configure looks like this:

PushNotification.configure({
  onNotification: handleNotificationClick,
  onAction: handleNotificationActionClick
});

function handleNotificationClick(notification) {
  const id = Platform.OS === "ios" ? notification.data.id : notification.id;
  
  RootNavigation.navigate("Question", {
    showBackButton: false,
    notificationId: id
  });
}

function handleNotificationActionClick(notification) {
  let vote;
  if (notification.action === "Yes") {
    vote = 1;
  } else if (notification.action === "No") {
    vote = 3;
  } else {
    showToast("Unknown action clicked. Please vote manually.");
    PushNotification.invokeApp(notification);
    return;
  }

  // Do some stuff while the app should not launch...
}

For Android everything works fine (including the actions). iOS works fine if the app was in fore- or background.
When the app was killed in iOS, the whole app launches and onNotification is not triggered.

[mathiasmoeller]

@Dallas62 any news? 😇

[Dallas62]

Hi @mathiasmoeller
Will try to look at it soon

[mathiasmoeller]

Thanks a lot! 🙏