-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: broken links and ui improvements #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes broken navigation links, improves UI consistency, corrects calculation bugs in ephemeral storage pricing, and adds a comprehensive comparison page showcasing advantages over AWS's official pricing tools.
- Replaced HTML anchor tags with React Router Link components for proper SPA navigation
- Fixed ephemeral storage calculation to use compute seconds instead of GB-seconds
- Added new comparison page with feature matrix and pricing examples
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| site/app/routes/home.tsx | Replaced anchor tags with Link components, added navigation handler for contributing section with scroll behavior |
| site/app/routes/demo.tsx | Fixed default free tier value from boolean to string for form consistency |
| site/app/routes/comparison.tsx | New comparison page showcasing calculator advantages over AWS tools with detailed feature matrix |
| site/app/routes/about.tsx | Added id attribute to contributing section for anchor navigation |
| site/app/routes.ts | Registered comparison route in application routing |
| site/app/entry.client.tsx | Added comparison component to client-side router configuration |
| site/app/components/Navbar.tsx | Added "VS AWS Tools" navigation link to header |
| aws-lambda-calculator/src/aws_lambda_calculator/calculator.py | Fixed ephemeral storage calculation bug by using compute seconds instead of GB-seconds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| const handleContributingClick = useCallback((e: React.MouseEvent<HTMLAnchorElement>) => { | ||
| e.preventDefault(); | ||
| navigate('/about', { state: { scrollTo: 'contributing' } }); |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider using { replace: false } explicitly or document the navigation behavior. Currently, this navigation adds a new history entry which may affect the back button behavior for users.
| navigate('/about', { state: { scrollTo: 'contributing' } }); | |
| navigate('/about', { state: { scrollTo: 'contributing' }, replace: false }); |
site/app/routes/comparison.tsx
Outdated
| <Link to="/demo" className="bg-white text-purple-600 px-6 py-3 rounded-lg font-semibold hover:bg-gray-100 transition-colors shadow-md"> | ||
| 🧮 Try the Calculator | ||
| </Link> | ||
| <Link to="/getting-started" className="bg-purple-700 text-white px-6 py-3 rounded-lg font-semibold hover:bg-purple-800 transition-colors shadow-md"> | ||
| 📖 Get Started | ||
| </Link> | ||
| <a href="https://github.com/zmynx/aws-lambda-calculator" target="_blank" rel="noopener noreferrer" | ||
| className="bg-slate-800 text-white px-6 py-3 rounded-lg font-semibold hover:bg-slate-700 transition-colors shadow-md"> |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call-to-action buttons should include focus states for keyboard navigation. Add focus:ring-2 focus:ring-offset-2 focus:ring-purple-500 or similar focus styling to improve accessibility.
| <Link to="/demo" className="bg-white text-purple-600 px-6 py-3 rounded-lg font-semibold hover:bg-gray-100 transition-colors shadow-md"> | |
| 🧮 Try the Calculator | |
| </Link> | |
| <Link to="/getting-started" className="bg-purple-700 text-white px-6 py-3 rounded-lg font-semibold hover:bg-purple-800 transition-colors shadow-md"> | |
| 📖 Get Started | |
| </Link> | |
| <a href="https://github.com/zmynx/aws-lambda-calculator" target="_blank" rel="noopener noreferrer" | |
| className="bg-slate-800 text-white px-6 py-3 rounded-lg font-semibold hover:bg-slate-700 transition-colors shadow-md"> | |
| <Link to="/demo" className="bg-white text-purple-600 px-6 py-3 rounded-lg font-semibold hover:bg-gray-100 transition-colors shadow-md focus:ring-2 focus:ring-offset-2 focus:ring-purple-500"> | |
| 🧮 Try the Calculator | |
| </Link> | |
| <Link to="/getting-started" className="bg-purple-700 text-white px-6 py-3 rounded-lg font-semibold hover:bg-purple-800 transition-colors shadow-md focus:ring-2 focus:ring-offset-2 focus:ring-purple-500"> | |
| 📖 Get Started | |
| </Link> | |
| <a href="https://github.com/zmynx/aws-lambda-calculator" target="_blank" rel="noopener noreferrer" | |
| className="bg-slate-800 text-white px-6 py-3 rounded-lg font-semibold hover:bg-slate-700 transition-colors shadow-md focus:ring-2 focus:ring-offset-2 focus:ring-purple-500"> |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|



User description
PR Type
Enhancement, Bug fix
Description
Add new comparison page showcasing advantages over AWS official tools
Fix calculation bug: return
total_compute_secinstead oftotal_compute_gb_secfor ephemeral storageFix broken navigation links: replace
<a>tags with<Link>components and add smooth scroll to contributing sectionUpdate demo form: change
include_free_tierfrom boolean to string type for proper form handlingDiagram Walkthrough
File Walkthrough
routes.ts
Add comparison route to router configurationsite/app/routes.ts
comparisonroute pointing toroutes/comparison.tsxapi-docsanddemoroutesentry.client.tsx
Register comparison route in client routersite/app/entry.client.tsx
Comparisoncomponent fromroutes/comparisoncomparisonapi-docsanddemoroutescalculator.py
Fix ephemeral storage calculation parameter bugaws-lambda-calculator/src/aws_lambda_calculator/calculator.py
calc_monthly_compute_charges()to returntotal_compute_secasthird value instead of
total_compute_gb_seccalc_monthly_ephemeral_storage_charges()parameter fromtotal_compute_gb_sectototal_compute_secvariable name
calculate()function to unpack the new return valuecorrectly
demo.tsx
Fix free tier toggle form typesite/app/routes/demo.tsx
include_free_tierform state from booleantrueto string'true'home.tsx
Fix broken navigation links and add smooth scrollsite/app/routes/home.tsx
Linkcomponent anduseNavigatehook for proper routingtags withcomponents for internal navigation (introduction,install-usage, demo)
handleContributingClickcallback to navigate to about page andsmooth scroll to contributing section
/aboutroutefunctionality
Navbar.tsx
Add comparison page link to navbarsite/app/components/Navbar.tsx
about.tsx
Add anchor ID for contributing sectionsite/app/routes/about.tsx
id="contributing"attribute to Contributing & License section foranchor linking
comparison.tsx
Create comprehensive comparison page with feature matrixsite/app/routes/comparison.tsx
Calculator vs AWS Pricing Calculator vs AWS Cost Calculator
tool
on modern configurations
GitHub