fix: exclude free tier. #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Contributor
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to exclude AWS Lambda free tier benefits from cost calculations. The changes add a new command-line flag --free-tier that allows users to toggle whether free tier benefits should be included in the cost estimation.
- Added
--free-tierCLI argument with choices "true"/"false" and default "true" - Updated both CLI and Lambda function handlers to pass the free tier flag to the calculator
- Enhanced calculation logging with improved decimal precision for cost factors
- Updated introduction page content with better formatting and clarity
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cli.py | Added --free-tier argument and passed it to the calculator function |
| src/aws_lambda.py | Extended Lambda handler to accept and forward the include_free_tier parameter |
| site/app/routes/introduction.tsx | Improved content formatting and readability in the backstory section |
| aws-lambda-calculator/src/aws_lambda_calculator/calculator.py | Enhanced logging precision by formatting cost factors to 8 decimal places |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lior Dux <lior.dux@develeap.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lior Dux <lior.dux@develeap.com>
…da-calculator into fix/bug-exclude-free-tier
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Bug fix
Description
Add
include_free_tierparameter to exclude AWS Lambda free tier benefitsFormat pricing rates with 8 decimal places for improved precision
Update CLI with
--free-tierflag to control free tier inclusionEnhance introduction documentation with clearer project narrative
Diagram Walkthrough
File Walkthrough
calculator.py
Format pricing rates with 8 decimal precisionaws-lambda-calculator/src/aws_lambda_calculator/calculator.py
rate,overflow_rate,requests_cost_factor,ephemeral_storage_cost_factor) with.8fformat specifier for 8 decimalprecision
request charges, and ephemeral storage charge logging and step
tracking
aws_lambda.py
Add include_free_tier parameter handlingsrc/aws_lambda.py
include_free_tierparameter from payload with default valueTrueinclude_free_tierparameter to calculator function callcli.py
Add CLI flag for free tier controlsrc/cli.py
--free-tiercommand-line argument accepting "true" or "false"choices with default "true"
calculations
install-usage.tsx
Fix file ending newlinesite/app/routes/install-usage.tsx
introduction.tsx
Enhance introduction narrative and claritysite/app/routes/introduction.tsx
limitations