-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry #25
Conversation
applied to the readers catching connection exceptions that I saw in the GH logs (don't seem to happen locally in my testing on Win...)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 97.44% 98.69% +1.25%
==========================================
Files 3 4 +1
Lines 430 461 +31
==========================================
+ Hits 419 455 +36
+ Misses 11 6 -5 ☔ View full report in Codecov by Sentry. |
Maybe just the Update: yes there was one case from get-data daily where |
would need some more complex testing with mocking
Trying CI multiple times, got `requests.exceptions.ReadTimeout` for URL /pub/data/uscrn/products/daily01/2001/ (in `get_year_urls` with `get_data`)
if many URLs are retried, could take long for now, for some runs this is < 1 min, for some, as long as 3 min
the above one applies to this too
until making it configurable so it can be shorter for the test
retry
decorator with backoff until max time (60 s) reached, a simplified (and currently inflexible) version of what backoff does, applied to the readers and cases of explicitrequests
usagerequests
usageResolves #21