This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Optionally leave shorthand instead parsing values#20
Closed
kopipejst wants to merge 7 commits intozmoazeni:masterfrom
Closed
Optionally leave shorthand instead parsing values#20kopipejst wants to merge 7 commits intozmoazeni:masterfrom
kopipejst wants to merge 7 commits intozmoazeni:masterfrom
Conversation
Owner
|
Thanks for submitting this @kopipejst! I'll take a look at this. I'm still on the fence whether shorthand matching should be the default or not but I'm thinking that regardless the default, it should be optional. |
|
@kopipejst +1 |
zmoazeni
added a commit
that referenced
this pull request
Apr 12, 2013
I'm fine with keeping shorthand matching the default, but I respect some people don't like it. refs: #20
Owner
|
@kopipejst @tamvo I've just committed something similar but with the reverse logic. Default stays the same but you can now run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using shorthand notation in CSS is good practice so even if there are duplicates in most cases is better to leave them.
Example test.css:
If we run
csscss -v test.css -n 1we'll get that there are 5 duplicates:{.bar} AND {.foo} share 5 rules
However, in this case splitting border or padding shorthand notation is not good practice in CSS because file will be larger.
With --use-shorthand option shorthand will not be parsed so we'll get only one duplicate.
csscss -v test.css -n 1 --use-shorthand{.bar} AND {.foo} share 1 rule