feat(boards): Add nice!60 board definition #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innovaker
suggested changes
May 27, 2021
There was a problem hiding this comment.
Thanks @Nicell!
Nothing particularly odd stood out except the deprecated codes.
Please also check:
- The copyright/license headers seem inconsistent?
- Copyright should be 2021.
- There's no
README.md?
plus some nickpicking. Pun intended.
I appreciate you've chosen to bypass setup.ps1, setup.sh, build.yml and hardware.md for now.
petejohanson
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the board definition for the nice!60, a stocked 60% PCB up for sale in the coming weeks. https://nicekeyboards.com/nice-60