-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contra shield #633
Add Contra shield #633
Conversation
iangus
commented
Jan 24, 2021
- Adds shield configuration for the Contra PCB
- Tested on nice!nano
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iangus This looks good! Clean and simple shield by the looks of it. Could you update the copyright year please?
@iangus Thanks for the quick response. We unfortunately have a long queue of shields we're working through, which requires a rebase after each one is merged in. I'll ping you again here when you're up for bat and we need you to rebase/make final changes. |
@Nicell sounds good. Just mention me here or in the discord, and I'll get this rebased/ready for merge. |
ceee2ec
to
89947bb
Compare
* fix contra keymap issues * add bluetooth control layer
89947bb
to
5cc2a28
Compare
Thank you, contributor, for your patience with how long review and merge of boards/shields has taken! There are three recent refactors/changes to boards and shields that require some attention, and then we can finally get this PR merged!
Hardware MetadataThe ProblemWhen first developing the process around contributing new shields/boards to ZMK, we failed to recognize that several key files (setup scripts, documentation page of supported hardware, and GH Action The FixBy adding discrete metadata files that are located with the boards/shields in question, and using that metadata to generate setup scripts, website hardware list, etc., users can contributing new hardware descriptions without the need to change the same files that other contributors are changing. Next StepsFirst, refer to https://zmk.dev/docs/development/hardware-metadata-files to familiarize yourself with the new metadata file format. Next, you have two options for fixing up your PR:
Pro Micro shield DT naming changesIn #876, we have simplified the DT naming for the "nexus node" we expose for pro-micro compatible boards, deprecating the use of Please see https://zmk.dev/docs/development/new-shield#shield-overlays for the updated docs on this. Split Shield Advertising ChangesIn addition, if this is a split PR, please see #658 where we have changed our conventions to remove the the name from the right sides, to prevent users attempting to pair with them and causing split sync issues. This also includes removing the " Left" suffix from the naming on the left side. See the changes in that PR for examples of what to change with your split shield. Getting HelpIf you have any questions about any of these changes, please comment here and tag @zmkfirmware/boards-shields or ask in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
* Add Contra Shield (zmkfirmware#1) * Add bluetooth control layer to contra keymap (zmkfirmware#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (zmkfirmware#1) * Add bluetooth control layer to contra keymap (zmkfirmware#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (#1) * Add bluetooth control layer to contra keymap (#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (zmkfirmware#1) * Add bluetooth control layer to contra keymap (zmkfirmware#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (#1) * Add bluetooth control layer to contra keymap (#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (#1) * Add bluetooth control layer to contra keymap (#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (zmkfirmware#1) * Add bluetooth control layer to contra keymap (zmkfirmware#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (zmkfirmware#1) * Add bluetooth control layer to contra keymap (zmkfirmware#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (zmkfirmware#1) * Add bluetooth control layer to contra keymap (zmkfirmware#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (#1) * Add bluetooth control layer to contra keymap (#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (moergo-sc#1) * Add bluetooth control layer to contra keymap (moergo-sc#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (#1) * Add bluetooth control layer to contra keymap (urob#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
* Add Contra Shield (#1) * Add bluetooth control layer to contra keymap (urob#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax