Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devcontainer): add volume mounts for zephyr, modules and tools #519

Merged

Conversation

innovaker
Copy link
Contributor

This effectively caches Zephyr and its dependencies. It also shares them between containers.

@innovaker innovaker added the enhancement New feature or request label Dec 15, 2020
@innovaker innovaker self-assigned this Dec 15, 2020
@innovaker innovaker marked this pull request as draft December 15, 2020 14:46
This effectively caches Zephyr and its dependencies.  It also shares them between containers.

PR: zmkfirmware#519
@innovaker innovaker force-pushed the devcontainer-add-zephyr-volume-mounts branch from 09d40c9 to d10bbe0 Compare December 15, 2020 14:47
@innovaker
Copy link
Contributor Author

Discussion of this PR concluded that the benefits of this change likely outweigh the potential problems.

@innovaker innovaker marked this pull request as ready for review December 17, 2020 11:11
@innovaker innovaker assigned petejohanson and unassigned innovaker Dec 17, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine here. I'm happy w/ this.

@petejohanson petejohanson merged commit 3b77266 into zmkfirmware:main Dec 18, 2020
@innovaker innovaker deleted the devcontainer-add-zephyr-volume-mounts branch December 18, 2020 16:09
makenova pushed a commit to makenova/zmk that referenced this pull request Dec 19, 2020
This effectively caches Zephyr and its dependencies.  It also shares them between containers.

PR: zmkfirmware#519
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
This effectively caches Zephyr and its dependencies.  It also shares them between containers.

PR: zmkfirmware#519
yuanbin pushed a commit to yuanbin/zmk that referenced this pull request Jun 14, 2023
This effectively caches Zephyr and its dependencies.  It also shares them between containers.

PR: zmkfirmware#519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants