ci(build): add support for board-only builds #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lays the groundwork for CI building boards that don't require shields. PR: zmkfirmware#464
innovaker
force-pushed
the
ci-build-optional-shields
branch
2 times, most recently
from
a8d1a41 to
9e00a67
Compare
innovaker
added a commit
to innovaker/zmk
that referenced
this pull request
Dec 4, 2020
Lays the groundwork for CI building boards that don't require shields. PR: zmkfirmware#464
innovaker
force-pushed
the
ci-build-optional-shields
branch
from
9e00a67 to
c2da73b
Compare
petejohanson
reviewed
Dec 4, 2020
.github/workflows/build.yml
Outdated
| if [ -n "${{ matrix.shield }}" ]; then | ||
| SHIELD="-DSHIELD=${{ matrix.shield }}" | ||
| fi | ||
| echo ::set-output name=shield::${SHIELD} |
There was a problem hiding this comment.
Thoughts on using something more generic, to allow other build steps to optionally add other defines?
There was a problem hiding this comment.
Yeah, that's a good question and that's actually what I did for zmk-docker's workflow (which is more refined).
I suspect in this case I was just powering through and didn't take a step back before pushing.
I can see the merits so I'll refactor it and re-push.
There was a problem hiding this comment.
That seems to have done the trick. This build (a PR which will build off this one) demonstrates the result:
https://github.com/zmkfirmware/zmk/runs/1501689317
innovaker
added a commit
to innovaker/zmk
that referenced
this pull request
Dec 4, 2020
Lays the groundwork for CI building boards that don't require shields. PR: zmkfirmware#464
innovaker
force-pushed
the
ci-build-optional-shields
branch
2 times, most recently
from
f3746a9 to
5aafeee
Compare
MangoIV
pushed a commit
to MangoIV/zmk
that referenced
this pull request
Dec 18, 2020
Lays the groundwork for CI building boards that don't require shields. PR: zmkfirmware#464
tyalie
pushed a commit
to tyalie/zmk
that referenced
this pull request
Nov 15, 2022
Lays the groundwork for CI building boards that don't require shields. PR: zmkfirmware#464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lays the groundwork for CI building boards that don't require shields.
Tested using
dz60rgb_rev1board. See https://github.com/innovaker/zmk/actions/runs/397136358 for results.