Skip to content

actions/upload-artifact v4 --> v6 for Node 24#3305

Merged
caksoylar merged 1 commit into
zmkfirmware:mainfrom
peterjc:patch-3
Mar 29, 2026
Merged

actions/upload-artifact v4 --> v6 for Node 24#3305
caksoylar merged 1 commit into
zmkfirmware:mainfrom
peterjc:patch-3

Conversation

@peterjc

@peterjc peterjc commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

This was the only change noted in their release notes:

https://github.com/actions/upload-artifact?tab=readme-ov-file#v6---whats-new

See eg issue #3303

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@peterjc
peterjc requested a review from a team as a code owner March 28, 2026 22:29

@caksoylar caksoylar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caksoylar
caksoylar merged commit 36d4518 into zmkfirmware:main Mar 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants