Skip to content

Conversation

sashasimkin
Copy link

Added shields splitkb_aurora_sofle_dongle and splitkb_aurora_sofle_peripheral_left to be able to build dongled configuration for this keyboard.

FWIW - the change was tested in my configuration build: https://github.com/sashasimkin/zmk-aurora-sofle-v2/actions/runs/18071698605

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@caksoylar
Copy link
Contributor

Hi there, thanks for the PR. I don't believe we intend to accept additional dongle shields for keyboards, and instead encourage folks to follow the recipe at https://zmk.dev/docs/development/hardware-integration/dongle within their own user config if they want to add a dongle to their keyboards that are maintained upstream. I think an exception could be considered if the keyboard ships with a dongle as a product (but that's not the case here AFAIK).

@caksoylar caksoylar added the shields PRs and issues related to shields label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants