-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BAS GATT reporting #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two super minor comments.
Co-authored-by: Pete Johanson <peter@peterjohanson.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi! Would it be possible to report the battery level of both halves in case of split keyboards? Either through the "master" (maybe with pressing some combo) or directly to the host via Bluetooth (if it's possible at all)? |
From what I've seen, Kinesis did something with their new Advantage360 Pro (the BT version) where a combo of keys lights up the LED's to display battery levels on each half...and they run on a custom ZMK firmware, so I'm guessing that's possible. Reading the docs however, it's currently un-supported https://zmk.dev/docs/features/battery |
This adds BAS GATT reporting using any device binding with the label
BATTERY
. Closes #47.Notes:
bt_gatt_bas_set_battery_level
has been renamed in Zephyr 2.4.0 -> Upgrade to Zephyr 2.4.0 #223zmk_battery_update
should eventually raise a battery event instead of directly posting to the BAS GATT