Skip to content

K_VOLUME_UP and K_VOLUME_DOWN work in macOS#3057

Merged
nmunnich merged 1 commit into
zmkfirmware:mainfrom
peterjc:patch-3
Sep 12, 2025
Merged

K_VOLUME_UP and K_VOLUME_DOWN work in macOS#3057
nmunnich merged 1 commit into
zmkfirmware:mainfrom
peterjc:patch-3

Conversation

@peterjc

@peterjc peterjc commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Tested via ZMK Studio, both the 'keyboard' and the 'consumer' volume up/down work on macOS Sequoia 15.6.1

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

Tested via ZMK Studio, both the 'keyboard' and the
'consumer' volume up/down work on macOS Sequoia 15.6.1
@peterjc
peterjc requested a review from a team as a code owner September 4, 2025 13:45
@peterjc

peterjc commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author
Screenshot 2025-09-04 at 14 45 38

@peterjc

peterjc commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

Also, can I setup K_VOLUME_UP2 and K_VOLUME_DOWN2 from Studio to test them too?

@caksoylar

Copy link
Copy Markdown
Contributor

It doesn't look like they are exposed in https://github.com/zmkfirmware/zmk-studio/blob/main/src/keyboard-and-consumer-usage-tables.json, it is supposed to be id 237-238 (0xED).

@peterjc

peterjc commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

Tweaking ZMK Studio and building it isn't something I was planning to tackle (to test K_VOLUME_UP2 and K_VOLUME_DOWN2).

I think this small PR is complete and ready to merge.

@nmunnich

nmunnich commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

I wonder if this should also be given a footnote about MacOS versions, considering #541

@peterjc

peterjc commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

Saying they didn't work in macOS "Big Sur" 11, but are working as of macOS "Sequoia" 15?

That can be narrowed down if we get more data.

@caksoylar caksoylar added the documentation Improvements or additions to documentation label Sep 12, 2025

@caksoylar caksoylar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK merging this as is. The footnote might be nice but if we can't get more testing done, then having the data for a recent version seems good enough.

@nmunnich
nmunnich merged commit df3db57 into zmkfirmware:main Sep 12, 2025
7 checks passed
@peterjc

peterjc commented Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

I realise I have an older Intel Mac stuck on an older version of macOS which I could try this on...

@peterjc
peterjc deleted the patch-3 branch September 12, 2025 14:03
jrsharp pushed a commit to jrsharp/zmk that referenced this pull request Nov 4, 2025
Tested via ZMK Studio, both the 'keyboard' and the
'consumer' volume up/down work on macOS Sequoia 15.6.1
ask-786 pushed a commit to ask-786/zmk that referenced this pull request Nov 16, 2025
Tested via ZMK Studio, both the 'keyboard' and the
'consumer' volume up/down work on macOS Sequoia 15.6.1
drewlwhitney pushed a commit to drewlwhitney/zmk that referenced this pull request Dec 22, 2025
Tested via ZMK Studio, both the 'keyboard' and the
'consumer' volume up/down work on macOS Sequoia 15.6.1
dgct pushed a commit to dgct/zmk that referenced this pull request Apr 28, 2026
Tested via ZMK Studio, both the 'keyboard' and the
'consumer' volume up/down work on macOS Sequoia 15.6.1
caksoylar pushed a commit to caksoylar/zmk that referenced this pull request May 27, 2026
Tested via ZMK Studio, both the 'keyboard' and the
'consumer' volume up/down work on macOS Sequoia 15.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants