Add zmk_kscan_gpio_demux kscan driver & NIBBLE keyboard #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innovaker
added
core
jaygreco
force-pushed
the
nullbitsco_nibble
branch
from
0c8d44d to
4e32e66
Compare
|
Fantastic feedback, thanks! I'm going to work on a rewrite over the next few days focusing on removing the unneeded features discussed above and adding the configurable polling rate. I'll push and update the PR when it's ready to go. |
jaygreco
force-pushed
the
nullbitsco_nibble
branch
from
a661e95 to
e3219bc
Compare
|
Alright! Made the changes discussed above. In summary:
|
jaygreco
force-pushed
the
nullbitsco_nibble
branch
from
e3219bc to
7e7594b
Compare
petejohanson
requested changes
Oct 27, 2020
|
@jaygreco Some merge conflicts since someone else added a board recently too. Can you quickly rebase w/ fixes for the setup scripts, then we'll merge? Thanks! |
|
@jaygreco Looks like this rebase didn't quite work as intended. Happy to help you on Discord if you need it. Thanks! |
+ zmk,kscan_gpio_demux is now a compatible kscan option + kscan_gpio_demux is based heavily off of the implementation of kscan_gpio_matrix, modified to address cols using an n-to-1 demultiplexer chip instead of discrete IO + Added zmk,kscan_gpio_demux.yaml file * modified CMakeLists to include new source files
+ Added required files for nullbits NIBBLE
- Revert accidental VS code settings change
- Remove kscan_gpio_irq_callback - Remove kscan_gpio_irq_callback_handler - Remove irq_callbacks + Add TODO noting timer and sleep state interactions
jaygreco
force-pushed
the
nullbitsco_nibble
branch
from
213b08c to
8a98212
Compare
MangoIV
pushed a commit
to MangoIV/zmk
that referenced
this pull request
Dec 18, 2020
Add zmk_kscan_gpio_demux kscan driver & NIBBLE keyboard
tyalie
pushed a commit
to tyalie/zmk
that referenced
this pull request
Nov 15, 2022
Add zmk_kscan_gpio_demux kscan driver & NIBBLE keyboard
|
Is this possible to support analog multiplexers (e.g. CD74HC4067) that output analog values (work with hall effect sensors and magnet switches)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NIBBLE keyboard folder and keymap. The biggest change is the addition of a new kscan driver, zmk_kscan_gpio_demux, along with some driver cleanup while porting from the standard matrix driver. I also added some comments to the driver.
The demux chip is active-low
and the driver allows for both row2col and col2row configurations. Currently, polling is the only method that has been tested as working, but hooks for interrupt-based scanning were left in as well for the future.Tested locally on a NIBBLE keyboard with nice!nano MCU.