refactor: physical layout consistency #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Munnich
force-pushed
the
physical-layouts-refactor-2
branch
from
00e5c51 to
c03a093
Compare
petejohanson
reviewed
Nov 4, 2024
There was a problem hiding this comment.
I generally favor this approach over #2582. One point of discussion.
caksoylar
reviewed
Nov 4, 2024
Nick-Munnich
force-pushed
the
physical-layouts-refactor-2
branch
6 times, most recently
from
6c34b67 to
192931c
Compare
petejohanson
reviewed
Nov 6, 2024
Nick-Munnich
force-pushed
the
physical-layouts-refactor-2
branch
from
192931c to
41c71d2
Compare
Nick-Munnich
force-pushed
the
physical-layouts-refactor-2
branch
from
41c71d2 to
610896c
Compare
petejohanson
approved these changes
Nov 6, 2024
Nick-Munnich
force-pushed
the
physical-layouts-refactor-2
branch
2 times, most recently
from
a8ce515 to
d29a952
Compare
caksoylar
requested changes
Nov 6, 2024
Nick-Munnich
force-pushed
the
physical-layouts-refactor-2
branch
from
d29a952 to
d11829d
Compare
|
Should be all good now. |
caksoylar
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to #2582, as suggested by Joel and supported by Pete. Felt multiple PRs would be better here, to allow us to compare the different versions more directly.
Overall it looks nice, but future refactors to make a layout shared would still often be slightly more involved than dragging and dropping into the shared folder - multiple layouts present = need to be uncoupled.