docs: Pulled the encoders section of the new shield guide out into its own page #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caksoylar
reviewed
Sep 30, 2024
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
|
Agree with and made all the suggested changes. I read through it again, not sure if there are any easy further improvements. Probably need to see what sort of help requests appear to know what to improve. |
caksoylar
approved these changes
Sep 30, 2024
rafaelromao
pushed a commit
to rafaelromao/zmk
that referenced
this pull request
Oct 8, 2024
…e#2510) Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
lammai
pushed a commit
to lammai/zmk
that referenced
this pull request
Oct 27, 2024
…e#2510) Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
EnotionZ
pushed a commit
to EnotionZ/zmk
that referenced
this pull request
Nov 6, 2024
…e#2510) Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
earwin
pushed a commit
to earwin/zmk
that referenced
this pull request
Nov 13, 2024
…e#2510) Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord. Should make the new shield guide a bit cleaner.