feat: Add support for switching to previously used bluetooth profile #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willelind
force-pushed
the
bluetooth-feature
branch
from
9419703 to
6915982
Compare
|
Regarding saving to memory, I think if you could get it to save both the current and previous profiles in a single write action to the same block, then it would be worth doing so. I'm not sure if that's possible, though, not looked into it. |
|
On going through this again, could probably add a test for this. |
petejohanson
requested changes
Feb 26, 2025
| @@ -33,6 +33,11 @@ static const struct behavior_parameter_value_metadata no_arg_values[] = { | |||
| .type = BEHAVIOR_PARAMETER_VALUE_TYPE_VALUE, | |||
| .value = BT_PRV_CMD, | |||
| }, | |||
| { | |||
| .display_name = "Previously Used Profile", | |||
There was a problem hiding this comment.
Suggested change
| .display_name = "Previously Used Profile", | |
| .display_name = "Previously Selected Profile", |
Comment on lines
+10
to
+13
| #define BT_PRV_DEV_CMD 3 | ||
| #define BT_SEL_CMD 4 | ||
| #define BT_CLR_ALL_CMD 5 | ||
| #define BT_DISC_CMD 6 |
There was a problem hiding this comment.
Add this at the end with a value of 6 please, otherwise this will break folks using ZMK Studio who've saved these few commands to their keymap.
Also, I am not a huge fan of including DEV in the naming here, versus "selection" as a noun instead. I think BT_PRV_SEL_CMD is preferable.
| @@ -23,6 +23,7 @@ | |||
| void zmk_ble_clear_bonds(void); | |||
| int zmk_ble_prof_next(void); | |||
| int zmk_ble_prof_prev(void); | |||
| int zmk_ble_prof_prev_dev(void); | |||
There was a problem hiding this comment.
Suggested change
| int zmk_ble_prof_prev_dev(void); | |
| int zmk_ble_prof_prev_selection(void); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to make it possible to switch to the index of the previously used profile. This is a feature I will need for my project (swapping between RPi and computer)
There are previous PRs offering this functionality, but they have comments that they didn't bother to fix, so I did it in this one.
I switched LAST_DEV to PRV_DEV as I think LAST could be misinterpreted to mean the last index of the list of profiles.
I also didn't add flash save for the previous_profile as exists for the active_profile. Instead I added initialize to 0, so each time you boot, the PRV_DEV will take you to index 0 for the first time, unless you switch profiles before pressing it with the other profile options. Maybe it should be saved but I thought it was a bit overkill for this, tell me if you want me to add this feature.
Fixes #767