fix(underglow): allow full range for initial brightness #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudongzheng
force-pushed
the
rgb-brt-pr
branch
2 times, most recently
from
bde01e9 to
ae09ee5
Compare
xudongzheng
force-pushed
the
rgb-brt-pr
branch
2 times, most recently
from
96dbea4 to
768459a
Compare
|
From your description this is a bug fix rather than a refactor, right? |
The brightness is already scaled within zmk_rgb_underglow_tick(). With the current range condition, setting max brightness to 20% results in starting with 4% (20% of 20%) brightness.
xudongzheng
changed the title
Yes, I suppose that would be more accurate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brightness is already scaled within zmk_rgb_underglow_tick(). With the current range condition, setting max brightness to 20% results in starting with 4% (20% of 20%) brightness.