Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Iris default build/Updated Dev Guide #187

Merged
merged 9 commits into from
Sep 20, 2020
Merged

Fixed Iris default build/Updated Dev Guide #187

merged 9 commits into from
Sep 20, 2020

Conversation

kurtis-lew
Copy link
Contributor

No description provided.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor items. Thanks!

app/boards/shields/iris/iris.keymap Show resolved Hide resolved
docs/docs/dev-guide-new-shield.md Outdated Show resolved Hide resolved
@kurtis-lew
Copy link
Contributor Author

@petejohanson addressed the things you wanted me to. Thanks!

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor item left.

docs/docs/dev-guide-new-shield.md Outdated Show resolved Hide resolved
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@petejohanson petejohanson added documentation Improvements or additions to documentation enhancement New feature or request shields PRs and issues related to shields split labels Sep 20, 2020
@petejohanson petejohanson merged commit 9b89ed7 into zmkfirmware:main Sep 20, 2020
MangoIV pushed a commit to MangoIV/zmk that referenced this pull request Dec 18, 2020
Fixed Iris default build/Updated Dev Guide
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
Fixed Iris default build/Updated Dev Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request shields PRs and issues related to shields split
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants