Allow to override body permissions checks in custom methods #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismfonseca
reviewed
Dec 9, 2016
| @@ -42,7 +42,7 @@ public CallServerInterceptor(boolean forWebSocket) { | |||
| long sentRequestMillis = System.currentTimeMillis(); | |||
| httpCodec.writeRequestHeaders(request); | |||
|
|
|||
| if (HttpMethod.permitsRequestBody(request.method()) && request.body() != null) { | |||
| if (request.isCustomMethod() || HttpMethod.permitsRequestBody(request.method()) && request.body() != null) { | |||
There was a problem hiding this comment.
request.body() != null && (request.isCustomMethod() || HttpMethod.permitsRequestBody(request.method()))
| @@ -69,6 +71,10 @@ public Object tag() { | |||
| return tag; | |||
| } | |||
|
|
|||
| public boolean bodyForcedlyAllowed() { | |||
There was a problem hiding this comment.
isBodyForcedlyAllowed is is more Javish.
zmarkan
force-pushed
the
custom_methods_with_body
branch
3 times, most recently
from
8cc3133
to
b8059ee
Compare
zmarkan
force-pushed
the
custom_methods_with_body
branch
from
b8059ee
to
5aa1a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.