Add brackets to IPv6 literals with standard ports in http module #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigaryte
changed the title
dadrian
approved these changes
Feb 8, 2022
mzpqnxow
pushed a commit
to mzpqnxow/zgrab2
that referenced
this pull request
Apr 15, 2022
Co-authored-by: erik <fake@not.real> zmap#329
constantinsander
pushed a commit
to COMSYS/quic-zgrab2
that referenced
this pull request
Sep 11, 2023
Co-authored-by: erik <fake@not.real> zmap/zgrab2#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP module will currently fail when given IPv6 literals using standard ports (80/http and 443/https). This is because the function
getHTTPURL()simply concatenatesproto + "://" + host + endpoint. For non-standard ports (e.g. 8080/http), the functionnet.JoinHostPort()is used, which will add brackets to IPv6 literals.How to Test
2001:558:6000:1234:5678:abcd:efininput.txt../zgrab2 http -f ~/input.txt. Observe error"error":"parse \"http://2001:558:6000:1234:5678:abcd:ef/\": invalid port \":ef\" after host"./zgrab2 http -f ~/input.txt -p 8080. Observe connection timeout.