Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnet: Optionally return result even on error #277

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

codyprime
Copy link
Member

Even if the server does not respond to the telnet commands, the
banner may have useful information. Add the option "--force-banner"
so that the banner string may be returned even on failure. If the option
is not specified, the origin behavior is unchanged.

Even if the server does not respond to the telnet commands, the
banner may have useful information.  Add the option "--force-banner"
so that the banner string may be returned even on failure.
Copy link
Contributor

@bwireman bwireman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests need to updated. LGTM otherwise

@codyprime
Copy link
Member Author

Looks like the tests need to updated. LGTM otherwise

Tests / Travis on zgrab2 have been broken for a while, alas. The Telnet tests themselves actually passed.

@codyprime codyprime merged commit 3613392 into master Oct 30, 2020
@codyprime codyprime deleted the jcody/telnet-banner branch October 30, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants