->parshaHebrew Show the wrong parsha next year!

[StaffCollab]

It shows next year ויקהל -פקודי together, but it will be separate.

[pintend]

Can you show code, it looks like its working

\Zman\Zman::parse('3/9/2024')->parsha === 'Vayakheil'

[StaffCollab]

@Shrage-Oberlander Please clarify.

Please check 2025, I spoke about next year

[pintend]

oh, i see. you are correct, it is wrong. I thought 2024 because you posted in 2023...

also #35

[zachweix]

I have worked on this project in the past, but you can check my more recent work at https://github.com/zachweix/PhpZmanim. I admit that I need to update the documentation, but if you are using a new enough version of the library you can get a date (make sure it's Shabbos, during the week it will return nothing) and get the parsha.

[pintend]

zman/src/Getters/Parsha.php

Line 89 in ec4a4f5

if ($shabbos === 21 || $shabbos === 26 || $shabbos === 27 || $shabbos === 29) {

zman/src/Getters/Parsha.php

Line 90 in ec4a4f5

return $this->parshios($shabbos + $offset).' - '.$this->parshios($shabbos + $offset + 1);

$shabbos === 21 so $this->assertEquals('Vayakheil', Zman::parse('03/22/2025')->parsha) fails

[pintend]

Pull request #36

[yskraus]

what about next weeks parsha?
is it also included in this commit?

[pintend]

No, its caused by a different bug on line 135 as you mentioned.

the issue i have with fixing it, is there are no tests that fail when we comment out the code and removing it "fixes" it for this year

[Shrage-Oberlander]

@pintend do you have a fixed version of the Vayakeil Pekidai issue for this year?