Don't set Symbol when loading asyncIterator #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this look like it's on the right track? |
|
Any updates here? |
danez
approved these changes
Feb 7, 2017
|
BTW, if we merge this, we should possibly revert babel/babel#5195, since that workaround would no longer be relevant. |
|
@taion this PR is not a completely correct fix - it will work only in some cases. Most likely, need to rewrite |
|
My apologies then. There's no urgency here on my part any more, BTW – babel/babel#5195 works around this adequately and even leads to slightly terser generated code on the Babel side. |
|
I'm going to close this given that the comment above that the implementation isn't correct. The workaround on Babel is sufficient for my purposes, plus we still have the tracking issue anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262, though I'm not sure how to test that.
Does this look right? This code doesn't seem to need to change
core.Symbolifcore.Symboldoesn't already exist, and the module buildingcore.Symbolwill pick up everything defined onwks.storeanyway.