Cache URL#toString#1533
Open
johnzhou721 wants to merge 3 commits into
Open
Conversation
zloirock
reviewed
Apr 2, 2026
| 'use strict'; | ||
| var $ = require('../internals/export'); | ||
| var call = require('../internals/function-call'); | ||
| var toString = URL.prototype.toString; |
Owner
There was a problem hiding this comment.
It will not work in the pure version and old engines.
Contributor
Author
There was a problem hiding this comment.
Hmm... so is this problem perhaps repairable? Or is it a fundamental limitation of old engines?
Can you be more specific about why this won't work in pure?
Owner
There was a problem hiding this comment.
URL is missed in old / ES-only engines. Global URL is missed after polyfilling in the pure version.
Owner
There was a problem hiding this comment.
You could use, for example, get-built-in-prototype-method.
Refactor URL.prototype.toString to use getBuiltInPrototypeMethod.
Contributor
Author
|
@zloirock This is ready for another look from you — Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches this method so if someone replaces URL#toString after they import core-js, things will not break.