Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1023

Merged
merged 26 commits into from
Dec 19, 2021
Merged

Spelling #1023

merged 26 commits into from
Dec 19, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 19, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@8d671e3#commitcomment-62181777

The action reports that the changes in this PR would make it happy: jsoref@6a0c6c3

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.


If you need things split, dropped, or squashed, just let me know, it isn't a big deal.

I will try to call out a bunch of things (it'll take time).

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@@ -434,7 +434,7 @@ const base = {
'sonarjs/no-empty-collection': ERROR,
// function calls should not pass extra arguments
'sonarjs/no-extra-arguments': ERROR,
// goolean expressions should not be gratuitous
// boolean expressions should not be gratuitous
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some repositories are whimsical; this repository does not appear to be one of them

README.md Outdated Show resolved Hide resolved
@@ -969,7 +969,7 @@ var createElement = __webpack_require__(39);

// Thank's IE8 for his funny defineProperty
module.exports = !DESCRIPTORS && !fails(function () {
// eslint-disable-next-line es/no-object-defineproperty -- requied for testing
// eslint-disable-next-line es/no-object-defineproperty -- required for testing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't want PRs to include changes to generated files. I'm not sure if this is one of them.

Let me know.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care - this file will be automatically regenerated on the next release.

@@ -114,7 +114,7 @@ The most important one is support for [`URL`](https://developer.mozilla.org/en-U

Another popular feature request was support for the [`.forEach` method on DOM collection](https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach). Since `core-js` already polyfilled iterators of DOM collections, why not add also `.forEach` to `NodeList` and `DOMTokenList`?

#### Removed obsolete featues:
#### Removed obsolete features:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, markdown best practice includes not including trailing : in headings. But that's far outside the scope of a spelling PR.

@@ -123,7 +123,7 @@

#### 移除过时的功能:

- `Reflect.enumrate` 因为他已经从标准中移除了
- `Reflect.enumerate` 因为他已经从标准中移除了
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally avoid touching non English content, but my tool doesn't care and is actually quite happy to check content that only uses latin letters for code.

As always, happy to drop.

@@ -264,7 +264,7 @@ import "regenerator-runtime/runtime";
import "core-js/modules/es.array.unscopables.flat";
import "core-js/modules/es.array.unscopaables.flat-map";
import "core-js/modules/es.object.from-entries";
import "core-js/modlues/web.immediate";
import "core-js/modules/web.immediate";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken code and would be bad for end users.

@@ -385,7 +385,7 @@ _matchAllInstanceProperty(string).call(string, /something/g);
有些老的问题已经被修复了。例如,下面这种流行的模式在 `@babel/runtime-corejs2` 不工作,但是在 `@babel/runtime-corejs3` 被支持。

```js
myArrayLikeObject[Symbol.tierator] = Array.prototype[Symbol.iterator];
myArrayLikeObject[Symbol.iterator] = Array.prototype[Symbol.iterator];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -278,7 +278,7 @@ var structuredCloneInternal = function (value, map) {
}
}
} catch (error) {
throw new DOMException('ArrayBuffer is deatched', DATA_CLONE_ERROR);
throw new DOMException('ArrayBuffer is detached', DATA_CLONE_ERROR);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is user facing

@@ -340,7 +340,7 @@ QUnit.test('URL#hostname', assert => {
// url = new URL('http://zloirock.ru:81/');
// url.hostname = 'example.com:82';
// assert.same(url.hostname, 'example.com'); // '' in Chrome
// assert.same(String(url), 'http://example.com:81/'); // 'ttp://example.com:82:81/' in Chrome
// assert.same(String(url), 'http://example.com:81/'); // 'http://example.com:82:81/' in Chrome
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this

@@ -207,7 +207,7 @@ const run = assert => {
}
try {
class F {
costructor(value) {
constructor(value) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scary?

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@@ -65,7 +65,7 @@ const run = assert => {
assert.same(Object('test string').search(/string/i), 5, 'S15.5.4.12_A2_T3');
assert.same(Object('test string').search(/Four/), -1, 'S15.5.4.12_A2_T4');
assert.same(Object('one two three four five').search(/four/), 14, 'S15.5.4.12_A2_T5');
assert.same(Object('test string').search('notexist'), -1, 'S15.5.4.12_A2_T6');
assert.same(Object('test string').search('nonexistent'), -1, 'S15.5.4.12_A2_T6');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a copy-paste from test262.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added to my list.

@zloirock
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants