review eslint core rules: disallow "Yoda" conditions

zloirock · Aug 16, 2023 · acaadf7 · acaadf7
1 parent 56cd6ff
commit acaadf7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/core-js/modules/es.date.set-year.js b/packages/core-js/modules/es.date.set-year.js
@@ -14,7 +14,7 @@ $({ target: 'Date', proto: true }, {
     // validate
     thisTimeValue(this);
     var yi = toIntegerOrInfinity(year);
-    var yyyy = 0 <= yi && yi <= 99 ? yi + 1900 : yi;
+    var yyyy = yi >= 0 && yi <= 99 ? yi + 1900 : yi;
     return setFullYear(this, yyyy);
   }
 });
diff --git a/packages/core-js/modules/web.url.constructor.js b/packages/core-js/modules/web.url.constructor.js
@@ -912,7 +912,7 @@ URLState.prototype = {
     if (search === '') {
       this.query = null;
     } else {
-      if ('?' === charAt(search, 0)) search = stringSlice(search, 1);
+      if (charAt(search, 0) === '?') search = stringSlice(search, 1);
       this.query = '';
       this.parse(search, QUERY);
     }
@@ -933,7 +933,7 @@ URLState.prototype = {
       this.fragment = null;
       return;
     }
-    if ('#' === charAt(hash, 0)) hash = stringSlice(hash, 1);
+    if (charAt(hash, 0) === '#') hash = stringSlice(hash, 1);
     this.fragment = '';
     this.parse(hash, FRAGMENT);
   },

diff --git a/tests/eslint/eslint.config.js b/tests/eslint/eslint.config.js
@@ -267,6 +267,8 @@ const base = {
   }],
   // require strict mode directives
   strict: [ERROR, 'global'],
+  // disallow "Yoda" conditions
+  yoda: [ERROR, NEVER],
 
   // layout & formatting:
   // enforce spacing inside array brackets