fix #393

zloirock · May 14, 2018 · 3ae8397 · 3ae8397
1 parent 9600ebb
commit 3ae8397
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 7 deletions.
diff --git a/packages/core-js/modules/es.reflect.set.js b/packages/core-js/modules/es.reflect.set.js
@@ -21,7 +21,7 @@ function set(target, propertyKey, V /* , receiver */) {
   if (has(ownDescriptor, 'value')) {
     if (ownDescriptor.writable === false || !isObject(receiver)) return false;
     if (existingDescriptor = getOwnPropertyDescriptorModule.f(receiver, propertyKey)) {
-      if (existingDescriptor.writable === false) return false;
+      if (existingDescriptor.get || existingDescriptor.set || existingDescriptor.writable === false) return false;
       existingDescriptor.value = V;
       definePropertyModule.f(receiver, propertyKey, existingDescriptor);
     } else definePropertyModule.f(receiver, propertyKey, createPropertyDescriptor(0, V));

diff --git a/tests/pure/es.reflect.set.js b/tests/pure/es.reflect.set.js
@@ -1,7 +1,7 @@
 import { DESCRIPTORS } from '../helpers/constants';
 
 import set from 'core-js-pure/features/reflect/set';
-import { defineProperty, getOwnPropertyDescriptor, create } from 'core-js-pure/features/object';
+import { defineProperty, getOwnPropertyDescriptor, create, getPrototypeOf } from 'core-js-pure/features/object';
 
 QUnit.test('Reflect.set', assert => {
   assert.isFunction(set);
@@ -68,8 +68,18 @@ QUnit.test('Reflect.set', assert => {
       writable: false,
       configurable: true,
     });
-    // eslint-disable-next-line
-    assert.strictEqual(set(o.__proto__, 'test', 1, o), false);
+    assert.strictEqual(set(getPrototypeOf(o), 'test', 1, o), false);
+
+    // https://github.com/zloirock/core-js/issues/393
+    o = defineProperty({}, 'test', {
+      get() { /* empty */ },
+    });
+    assert.notThrows(() => !set(getPrototypeOf(o), 'test', 1, o));
+    o = defineProperty({}, 'test', {
+      // eslint-disable-next-line no-unused-vars
+      set(v) { /* empty */ },
+    });
+    assert.notThrows(() => !set(getPrototypeOf(o), 'test', 1, o));
   }
   assert.throws(() => set(42, 'q', 42), TypeError, 'throws on primitive');
 });
diff --git a/tests/tests/es.reflect.set.js b/tests/tests/es.reflect.set.js
@@ -2,7 +2,7 @@ import { DESCRIPTORS, NATIVE } from '../helpers/constants';
 
 QUnit.test('Reflect.set', assert => {
   const { set } = Reflect;
-  const { defineProperty, getOwnPropertyDescriptor, create } = Object;
+  const { defineProperty, getOwnPropertyDescriptor, create, getPrototypeOf } = Object;
   assert.isFunction(set);
   if (NATIVE) assert.arity(set, 3);
   assert.name(set, 'set');
@@ -68,8 +68,18 @@ QUnit.test('Reflect.set', assert => {
       writable: false,
       configurable: true,
     });
-    // eslint-disable-next-line
-    assert.strictEqual(set(o.__proto__, 'test', 1, o), false);
+    assert.strictEqual(set(getPrototypeOf(o), 'test', 1, o), false);
+
+    // https://github.com/zloirock/core-js/issues/393
+    o = defineProperty({}, 'test', {
+      get() { /* empty */ },
+    });
+    assert.notThrows(() => !set(getPrototypeOf(o), 'test', 1, o));
+    o = defineProperty({}, 'test', {
+      // eslint-disable-next-line no-unused-vars
+      set(v) { /* empty */ },
+    });
+    assert.notThrows(() => !set(getPrototypeOf(o), 'test', 1, o));
   }
   assert.throws(() => set(42, 'q', 42), TypeError, 'throws on primitive');
 });