fix #392

zloirock · Apr 20, 2018 · 2774ed2 · 2774ed2
1 parent 249f750
commit 2774ed2
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/packages/core-js/modules/es.reflect.set.js b/packages/core-js/modules/es.reflect.set.js
@@ -20,9 +20,11 @@ function set(target, propertyKey, V /* , receiver */) {
   }
   if (has(ownDescriptor, 'value')) {
     if (ownDescriptor.writable === false || !isObject(receiver)) return false;
-    existingDescriptor = getOwnPropertyDescriptorModule.f(receiver, propertyKey) || createPropertyDescriptor(0);
-    existingDescriptor.value = V;
-    definePropertyModule.f(receiver, propertyKey, existingDescriptor);
+    if (existingDescriptor = getOwnPropertyDescriptorModule.f(receiver, propertyKey)) {
+      if (existingDescriptor.writable === false) return false;
+      existingDescriptor.value = V;
+      definePropertyModule.f(receiver, propertyKey, existingDescriptor);
+    } else definePropertyModule.f(receiver, propertyKey, createPropertyDescriptor(0, V));
     return true;
   }
   return ownDescriptor.set === undefined ? false : (ownDescriptor.set.call(receiver, V), true);

diff --git a/tests/pure/es.reflect.set.js b/tests/pure/es.reflect.set.js
@@ -62,6 +62,14 @@ QUnit.test('Reflect.set', assert => {
     assert.strictEqual(target.u, 0, 'set u');
     assert.strictEqual(set(target, 'c', 2, target), false, 'set c');
     assert.strictEqual(target.c, 1, 'set c');
+
+    // https://github.com/zloirock/core-js/issues/392
+    const o = defineProperty({}, 'test', {
+      writable: false,
+      configurable: true,
+    });
+    // eslint-disable-next-line
+    assert.strictEqual(set(o.__proto__, 'test', 1, o), false);
   }
   assert.throws(() => set(42, 'q', 42), TypeError, 'throws on primitive');
 });
diff --git a/tests/tests/es.reflect.set.js b/tests/tests/es.reflect.set.js
@@ -62,6 +62,14 @@ QUnit.test('Reflect.set', assert => {
     assert.strictEqual(target.u, 0, 'set u');
     assert.strictEqual(set(target, 'c', 2, target), false, 'set c');
     assert.strictEqual(target.c, 1, 'set c');
+
+    // https://github.com/zloirock/core-js/issues/392
+    const o = defineProperty({}, 'test', {
+      writable: false,
+      configurable: true,
+    });
+    // eslint-disable-next-line
+    assert.strictEqual(set(o.__proto__, 'test', 1, o), false);
   }
   assert.throws(() => set(42, 'q', 42), TypeError, 'throws on primitive');
 });