Skip to content

Commit

Permalink
feat: remove Provider.getConfirmedTokens method
Browse files Browse the repository at this point in the history
BREAKING CHANGE: this method will be removed from JSON RPC API.
  • Loading branch information
popzxc authored and danijelTxFusion committed Dec 19, 2023
1 parent 59f2df6 commit a761751
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
11 changes: 3 additions & 8 deletions src/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ export class Provider extends ethers.providers.JsonRpcProvider {
if (l2WethToken != ethers.constants.AddressZero) {
return l2WethToken;
}
} catch (e) {}
} catch (e) { }
const l2Erc20Bridge = IL2BridgeFactory.connect(bridgeAddresses.erc20L2, this);
return await l2Erc20Bridge.l2TokenAddress(token);
}
Expand All @@ -418,7 +418,7 @@ export class Provider extends ethers.providers.JsonRpcProvider {
if (l1WethToken != ethers.constants.AddressZero) {
return l1WethToken;
}
} catch (e) {}
} catch (e) { }
const erc20Bridge = IL2BridgeFactory.connect(bridgeAddresses.erc20L2, this);
return await erc20Bridge.l1TokenAddress(token);
}
Expand Down Expand Up @@ -580,11 +580,6 @@ export class Provider extends ethers.providers.JsonRpcProvider {
};
}

async getConfirmedTokens(start: number = 0, limit: number = 255): Promise<Token[]> {
const tokens: Token[] = await this.send("zks_getConfirmedTokens", [start, limit]);
return tokens.map((token) => ({ address: token.l2Address, ...token }));
}

async getTokenPrice(token: Address): Promise<string | null> {
return await this.send("zks_getTokenPrice", [token]);
}
Expand Down Expand Up @@ -668,7 +663,7 @@ export class Provider extends ethers.providers.JsonRpcProvider {
let l1WethToken = ethers.constants.AddressZero;
try {
l1WethToken = await l2WethBridge.l1TokenAddress(tx.token);
} catch (e) {}
} catch (e) { }
tx.bridgeAddress =
l1WethToken != ethers.constants.AddressZero
? bridgeAddresses.wethL2
Expand Down
9 changes: 1 addition & 8 deletions tests/integration/provider.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect } from "chai";
import { Provider, types, utils, Wallet } from "../../src";
import { BigNumber, ethers } from "ethers";
import {TOKENS} from "../const";
import { TOKENS } from "../const";

describe("Provider", () => {
const ADDRESS = "0x36615Cf349d7F6344891B1e7CA7C72883F5dc049";
Expand Down Expand Up @@ -141,13 +141,6 @@ describe("Provider", () => {
});
});

describe("#getConfirmedTokens()", () => {
it("should return confirmed tokens", async () => {
const result = await provider.getConfirmedTokens();
expect(result).to.have.lengthOf(2);
});
});

describe("#getDefaultBridgeAddresses()", () => {
it("should return default bridges", async () => {
const result = await provider.getDefaultBridgeAddresses();
Expand Down

0 comments on commit a761751

Please sign in to comment.