Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18 spec serialization #24

Merged
merged 18 commits into from
Oct 15, 2024
Merged

18 spec serialization #24

merged 18 commits into from
Oct 15, 2024

Conversation

martonmoro
Copy link
Collaborator

Issue: #18

@martonmoro martonmoro self-assigned this Oct 2, 2024
@martonmoro
test: serialize basic types, change enum to class
6194352
@martonmoro
feat: implement serializeNestedProvableFor with tests
8a962e5
@martonmoro
chore: add tests for convertInputToSerializable and implement seriali…
d1913c6 
…zeProvable
@martonmoro
test and ci: add tests for convertNodeToSerializable and add serializ…
8303279 
…e test to ci
@martonmoro
test: add tests for convertSpecToSerializable
83dd28a
@martonmoro
chore(wip): deserialize skeleton
d5c635a
@martonmoro
chore and test: add deserializeProvable and deserializeProvableType w…
5d19141 
…ith tests
@martonmoro
chore, test, ci: add deserializeInput with tests
9697a9b
@martonmoro
test: add tests for deserializeInputs
b31ec0b
@martonmoro
delete comments
c43241a
@martonmoro
chore and test: add deserializeNode with tests
81f5feb
@martonmoro
test: add simple test for deserializeSpec
4138510
@martonmoro
test: add tests for deserializeSpec
ae2d703
@martonmoro
typo
76ab35e
@martonmoro
feat: add hashing to serialization
835048f
@martonmoro martonmoro marked this pull request as ready for review October 14, 2024 13:42
mitschabaude
mitschabaude reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, leaving a few comments

src/deserialize-spec.ts Outdated Show resolved Hide resolved
src/deserialize-spec.ts Outdated Show resolved Hide resolved
src/deserialize-spec.ts Outdated Show resolved Hide resolved
src/deserialize-spec.ts Outdated Show resolved Hide resolved
src/serialize-spec.ts Outdated Show resolved Hide resolved
src/serialize-spec.ts Outdated Show resolved Hide resolved
src/serialize-spec.ts Outdated Show resolved Hide resolved
src/deserialize-spec.ts Outdated Show resolved Hide resolved
tests/deserialize.test.ts Outdated Show resolved Hide resolved
src/serialize-spec.ts Outdated Show resolved Hide resolved
mitschabaude
mitschabaude approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@martonmoro martonmoro merged commit 084b4c6 into main Oct 15, 2024
2 checks passed
@martonmoro martonmoro deleted the 18-spec-serialization branch October 15, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees

@martonmoro martonmoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martonmoro @mitschabaude