-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create verifyWithDataAttestation.sol #293
feat: Create verifyWithDataAttestation.sol #293
Conversation
for reading on-chain inputs from .json file and then setting those as pubInputs to the circuit
This reverts commit c409118.
'hash-of-inputs-outputs' into feat-verify-evm-with-data-attestation
*created verify_proof_with_data_attestation for testing
'development' into feat-verify-evm-with-data-attestation
…verify-evm-with-data-attestation
*added integration tests
*fixed wasm tests *fixed all of the python tests
src/commands.rs
Outdated
@@ -159,6 +162,10 @@ pub struct RunArgs { | |||
/// Flags whether params are public, private, hashed | |||
#[arg(long, default_value = "private")] | |||
pub param_visibility: Visibility, | |||
/// Base used to pack the public-inputs to the circuit. (value > 1) to pack instances as a single int. | |||
/// Useful when verifying on the EVM. Note that this will often break for very long inputs. Use with caution, still experimental. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm this
src/commands.rs
Outdated
@@ -188,6 +195,10 @@ impl Cli { | |||
pub fn from_json(arg_json: &str) -> Result<Self, serde_json::Error> { | |||
serde_json::from_str(arg_json) | |||
} | |||
/// Create an ezkl configuration: if there is an EZKLCONF env variable, parse its value, else read it from the command line. | |||
pub fn create() -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm this
.github/workflows/rust.yml
Outdated
@@ -144,22 +144,18 @@ jobs: | |||
run: cargo test --release --verbose tests::mock_public_outputs_ -- --test-threads 32 | |||
- name: Mock proving tests (public outputs + batch size == 10) | |||
run: cargo test --release --verbose tests::mock_large_batch_public_outputs_ -- --test-threads 32 | |||
- name: Mock proving tests (public and packed outputs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm this
.github/workflows/rust.yml
Outdated
@@ -144,22 +144,18 @@ jobs: | |||
run: cargo test --release --verbose tests::mock_public_outputs_ -- --test-threads 32 | |||
- name: Mock proving tests (public outputs + batch size == 10) | |||
run: cargo test --release --verbose tests::mock_large_batch_public_outputs_ -- --test-threads 32 | |||
- name: Mock proving tests (public and packed outputs) | |||
run: cargo test --release --verbose packed_tests::mock_packed_outputs_ -- --test-threads 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm this
.github/workflows/rust.yml
Outdated
- name: Mock proving tests (public inputs) | ||
run: cargo test --release --verbose tests::mock_public_inputs_ -- --test-threads 32 | ||
- name: Mock proving tests (public params) | ||
run: cargo test --release --verbose tests::mock_public_params_ -- --test-threads 32 | ||
- name: Mock 'everything' tests (public and packed outputs, public inputs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm this
into feat-verify-evm-with-data-attestation
d74d2ef
to
40106eb
Compare
to serialize for GraphInput struct.
Allows users to read inputs to their EZKL models directly on-chain and attest to them when verifying.
**run args**
:—on-chain-inputs=true
.input.json
used by EZKL to include a field defining where to read the inputs from on-chain.address
andcallData
that EZKL will statically call into.decimals
field of the callData determines the number of decimal places in the on chain data to scale by. So for instance if the decimals is set to3
for a raw on chain input value of1111
it will get converted to1.111
floating point value.