Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring, tests and performance increase #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

peterkrull
Copy link

Hello. I have made some changes in my own fork.

  • Made SBusPacket struct entries public
  • Added feature to support embedded_hal::serial::Read<u8> trait
  • Extensive use of ? operator during try_parse
  • Fixed is_flag_set seemingly not doing what it was supposed to
  • Simplified bit-shifting section, parsing is ~60% faster on an RP2040

Of course feel free to change the package description back to how it was.

@zklapow
Copy link
Owner

zklapow commented Jan 31, 2023

Thanks for this peter, I hope you don't mind I updated the cargo.toml here to include us both as authors and link to this git repo (given you are PRing here!)

@peterkrull
Copy link
Author

That's perfectly fine. I should also add, I removed the Taranis related file, since it did not seem too relevant for the purpose of the crate

@peterkrull
Copy link
Author

Hey, just want to say this never got merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants