Skip to content

Conversation

@tarcieri
Copy link
Contributor

Adds a provided method to the Group trait for performing multiplication by the generator.

The use case is overriding this method in the event that precomputed scalar multiplication tables are available, which may be conditional depending on crate features like alloc or feature-gated static precomputed tables.

Adds a provided method to the `Group` trait for performing
multiplication by the generator.

The use case is overriding this method in the event that precomputed
scalar multiplication tables are available, which may be conditional
depending on crate features like `alloc` or feature-gated static
precomputed tables.
Copy link
Member

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks!

This is adding a provided method to a trait, which is a possibly-breaking change. Per existing precedent for these crates, I consider it a minor change, so we can push this out with a point release. I will hold off merging this PR however until the other bugfix PRs are ready so I can determine what the content of the next release will be.

@str4d
Copy link
Member

str4d commented Jul 29, 2023

Re-linking #45 here because I'd forgotten about that issue, and it is relevant to whether we merge this PR.

@tarcieri
Copy link
Contributor Author

tarcieri commented Jul 29, 2023

The use case described in #45 was a generator stored as static data which should work fine with this API.

@tarcieri
Copy link
Contributor Author

@str4d this one should be good to go as well, I think

@str4d
Copy link
Member

str4d commented Apr 16, 2025

Yeah, I'm inclined to include this in the 0.14.0 RFC for feedback, as #45 hasn't resolved and meanwhile Self::generator already exists.

@str4d str4d changed the base branch from main to release-0.14.0 April 16, 2025 19:30
@str4d str4d merged commit 6636782 into zkcrypto:release-0.14.0 Apr 16, 2025
@tarcieri tarcieri deleted the mul_by_generator branch September 3, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants