doc: document #[diagnostic(transparent)]
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavrilikhin-d
commented
May 14, 2023
| @@ -198,6 +198,18 @@ | |||
| //! #[error("Oops it blew up")] | |||
| //! #[diagnostic(code(my_lib::bad_code))] | |||
| //! BadThingHappened, | |||
| //! | |||
| //! #[error(transparent)] | |||
There was a problem hiding this comment.
Shouldn't #[diagnostic(transparent)] imply #[error(transparent)]?
There was a problem hiding this comment.
miette is blissfully unaware of thiserror. They are completely separate macros, and miette doesn't actually do anything related to std::error::Error itself.
There was a problem hiding this comment.
@zkat If you're using darling (https://github.com/TedDriggs/darling) you can parse #[error] attributes and infer settings from it. This would help to avoid all the duplicate info in some cases.
|
|
gavrilikhin-d
changed the title
#[diagnostic(transparent)]#[diagnostic(transparent)]
|
You need to install cargo-make first |
|
@zkat Hi! I've updated readme. Do I need to do something else to get this merged? |
zkat
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.