Skip to content
This repository has been archived by the owner on Jun 12, 2022. It is now read-only.

Switch back to proxy-agent #31

Open
zkat opened this issue Jun 8, 2017 · 3 comments
Open

Switch back to proxy-agent #31

zkat opened this issue Jun 8, 2017 · 3 comments

Comments

@zkat
Copy link
Owner

zkat commented Jun 8, 2017

#8 was done because of the massive deps that were getting included with pac-resolver. This was apparently fixed!, which means we can take out the m-f-h-side logic for this and just fall back to proxy-agent again. That should simplify the agent impl a bit 👍

Whoever does this should also comb through the code and make sure proxy-agent is doing everything we need to do over on our end, in case I forgot about something that was added since.

@silverwind
Copy link

proxy-agent now supports parsing proxy variables from the environment, so the environment parsing done in module can potentially be removed with such a switch.

@zkat
Copy link
Owner Author

zkat commented Jul 10, 2018

@silverwind you wanna PR that? :)

@silverwind
Copy link

Maybe later, I see that proxy-agent currently prints a nasty warning on installation, so let's wait until TooTallNate/node-proxy-agent#27 is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants