Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Create new release with socks-proxy updated #27

Closed
txusinho opened this issue Jun 18, 2018 · 2 comments · Fixed by #55
Closed

Create new release with socks-proxy updated #27

txusinho opened this issue Jun 18, 2018 · 2 comments · Fixed by #55

Comments

@txusinho
Copy link

Dear @TooTallNate,

According to the last tag of this package(3.0.0 on 65fcf7a), the socks-proxy-agent is set to 3.0.0 (

"socks-proxy-agent": "^3.0.0"
).

Current master branch is updated (d67cb23), but there's no way to fetch that fix with an exact version of the package.

I kindly ask you to tag a new version in this repo, so that I can send another PR to the people of nightwatch to fix the following vulnerability:


socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0

Thank you for your time reading this issue

@SkyHacks
Copy link
Contributor

@TooTallNate This issue is also blocking a PR I'm creating for superagent-proxy to remove the socks deprecation warning.

@xzyfer
Copy link

xzyfer commented Aug 19, 2019

Is this resolved now that #30 has been merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants