Improve OP fee estimation #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for OP fee estimation:
Results:
Relayer estimations were done using gas price values from block explorer for particular transactions. Native price feed was used for more demonstrative comparison.
Permittable deposit (link):
Size - 946 bytes
Actual fee - 0.000174409090047087 ETH
Relayer estimation - 0.000174873388706732 ETH
Difference - +0.26% (user overpays)
Transfer with four notes (link):
Size - 1542 bytes
Actual fee - 0.00052285667596097 ETH
Relayer estimation - 0.000522136726108933 ETH
Difference - -0.13% (user underpays)